Use viewBindingIgnore="true" when we do not need the ViewBinding.#4652
Merged
Use viewBindingIgnore="true" when we do not need the ViewBinding.#4652
Conversation
ouchadam
approved these changes
Dec 13, 2021
Contributor
There was a problem hiding this comment.
compiled and works locally fine for me 💯
*clean assembleGplayDebug --no-build-cache
| BEFORE | AFTER | |
|---|---|---|
| mean | 165,750.20 ms | 164,045.18 ms |
| min | 164,316.65 ms | 162,968.08 ms |
| p25 | 165,173.92 ms | 163,359.73 ms |
| median | 166,031.20 ms | 163,751.38 ms |
very minor gains to build time~ in comparison to the total time, but... with more modules and parallelisation this could help even more
Member
Author
|
I am now wondering if we could use ViewBinding in our VectorEpoxyHolder, or change the bit our arch to be able to do so. |
Contributor
depends if we want to start putting our eggs in the compose basket 🤔 |
Member
Author
|
Ok, thanks for the measures 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are using Epoxy and do not need the view binding for the vast majority of list item layouts. Disable their generation and compilation and finally Proguard shrink to have a faster compilation. Let's see if the gain worth it on the CI.
See https://developer.android.com/topic/libraries/view-binding for more details